-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] maintenance_timesheet: Migration to 17.0 #418
[17.0][MIG] maintenance_timesheet: Migration to 17.0 #418
Conversation
[UPD] Update maintenance_timesheet.pot pre-commit update Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-13.0/maintenance-13.0-maintenance_timesheet Translate-URL: https://translation.odoo-community.org/projects/maintenance-13-0/maintenance-13-0-maintenance_timesheet/
[UPD] Update maintenance_timesheet.pot [UPD] README.rst maintenance_timesheet 13.0.1.1.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-13.0/maintenance-13.0-maintenance_timesheet Translate-URL: https://translation.odoo-community.org/projects/maintenance-13-0/maintenance-13-0-maintenance_timesheet/
[UPD] Update maintenance_timesheet.pot [UPD] README.rst
Currently translated at 100.0% (21 of 21 strings) Translation: maintenance-14.0/maintenance-14.0-maintenance_timesheet Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_timesheet/it/
…est form view. TT40881 [UPD] Update maintenance_timesheet.pot maintenance_timesheet 14.0.2.1.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-14.0/maintenance-14.0-maintenance_timesheet Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_timesheet/
Currently translated at 100.0% (25 of 25 strings) Translation: maintenance-14.0/maintenance-14.0-maintenance_timesheet Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_timesheet/it/ [UPD] Update maintenance_timesheet.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-14.0/maintenance-14.0-maintenance_timesheet Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_timesheet/
Currently translated at 100.0% (25 of 25 strings) Translation: maintenance-15.0/maintenance-15.0-maintenance_timesheet Translate-URL: https://translation.odoo-community.org/projects/maintenance-15-0/maintenance-15-0-maintenance_timesheet/it/
Currently translated at 100.0% (25 of 25 strings) Translation: maintenance-15.0/maintenance-15.0-maintenance_timesheet Translate-URL: https://translation.odoo-community.org/projects/maintenance-15-0/maintenance-15-0-maintenance_timesheet/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-16.0/maintenance-16.0-maintenance_timesheet Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_timesheet/
Currently translated at 100.0% (22 of 22 strings) Translation: maintenance-16.0/maintenance-16.0-maintenance_timesheet Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_timesheet/es/
Currently translated at 100.0% (22 of 22 strings) Translation: maintenance-16.0/maintenance-16.0-maintenance_timesheet Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_timesheet/it/
Currently translated at 100.0% (22 of 22 strings) Translation: maintenance-16.0/maintenance-16.0-maintenance_timesheet Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_timesheet/it/
Hello, this PR actually depends on #401 , you can temporary add a test-requirements.txt file linking to it. |
Yes, I know it and it's a todo task for #401 , not sure but it only might affect to tests. Anyway, if test-requirements.txt is added to this PR, it could help to runboat successful load and then, enable testing on it, if I'm not wrong. |
@FernandoRomera could you make a rebase? |
852700c
to
7dd8f45
Compare
@dalonsod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only code review, see minor changes requested. And please check tests improvement needed
Pressing on the "Hours" button I get Caused by: Error: "account.analytic.line"."is_timer_running" field is undefined. |
7dd8f45
to
bd85f98
Compare
I can not reproduce it on runbot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe because I'm using enterprise? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
On my way to merge this fine PR! |
Congratulations, your PR was merged at dee55f0. Thanks a lot for contributing to OCA. ❤️ |
No description provided.